Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image block: allow users to select a miniature? #1163

Closed
cekk opened this issue Feb 3, 2020 · 7 comments
Closed

Image block: allow users to select a miniature? #1163

cekk opened this issue Feb 3, 2020 · 7 comments

Comments

@cekk
Copy link
Member

cekk commented Feb 3, 2020

I don't know if this is a topic already discussed, but for me it could be useful adding a "miniature" field in image block configuration, to select what miniature to use for the image in the text.

I have several cases where i migrate pages from old sites and images are very large because they are used in different places, but in the text they use a smaller miniature..and in Volto they appear too big ;)

@tisto
Copy link
Member

tisto commented Apr 21, 2020

@cekk can you elaborate a bit on this? I don't fully understand this TBH. :)

@datakurre
Copy link
Member

@cekk @sneridagh So, my opinion on that was that let's not add miniature field, but use picture tag with sources with sizes. Once those are defined, browser should pick whatever size is the best for the defined area.

If you later want to give editor more options on image size, give something that makes more sense for editor than miniature option with Plone image scales vocabulary. Then it is up to the integrator to configure Plone to provide such scales that give best experience with the current image uses. The best part is that Plone image scales could be change later because they are not referred directly, but they just affect the available sizes in source-tag.

@cekk
Copy link
Member Author

cekk commented May 5, 2020

Ok, @nzambello was supposed to reply to this thread some weeks ago ;)
My use-case was that on Plone, editors can choose which miniature include into text based on their needs in that particular content.
With Volto we can only choose alignment and use the original image. And the integrator can scale it in the theme. But editors can't choose its dimension.

Of course we could customize that widget/block to allow miniatures selection, but i wanted to know if that's a feature that we don't want to have in Volto because we don't want to give users the powers to choose a miniature by default (and let the browsers/themes choose the right one based on screen size). I'm not talking about cropping or something else, just to do what we can do in classic Plone in Tiny.

@tisto
Copy link
Member

tisto commented May 22, 2020

Add_Document (1)

@tisto
Copy link
Member

tisto commented May 28, 2020

After giving this some thought I think we should add two new buttons to the alignment list with smaller images, so we have:

  • Image left
  • Image left with a small image
  • Image right
  • Image right with a small image
  • Image center
  • Image full width

@cekk
Copy link
Member Author

cekk commented May 28, 2020

can't agree more ;)

@tisto
Copy link
Member

tisto commented Jun 18, 2020

Implemented and released.

@tisto tisto closed this as completed Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants