Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide custom.css view for TTW CSS customizations without cloning a theme. #3086

Open
MrTango opened this issue Apr 20, 2020 · 1 comment
Open
Assignees

Comments

@MrTango
Copy link
Contributor

MrTango commented Apr 20, 2020

Since we will use Bootstrap 4 and SCSS instead of LESS, we should also have a simple way of changing colors aso without having to clone a full theme.

The custom.css view in plone.app.thing will allow this.
The user can define some custom CSS in the Theming control panel, this get's stored in the Plone registry and rendered by the custom.css view.
The view will be registered as a ressource like any other ressource in Plone, but must be loaded at the very end to allow overriding other CSS.

part of #2967

@MrTango MrTango changed the title custom.css view Provide custom.css view for TTW CSS customizations without cloning a theme. Apr 20, 2020
@MrTango MrTango self-assigned this Apr 20, 2020
@mauritsvanrees
Copy link
Member

Status update:

One thing I notice: the custom.css is also loaded on the Theming control panel. So Diazo is never applied there, but this new custom css is.
For me, this is fine. It is just not what I expected.

I guess theoretically this means you can lock yourself out. Quite simple actually: body {display: none} is enough. :-)
Anyway, there are more ways to shoot yourself in the foot with Plone. I am not worried.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants