Editing images after inserted in TinyMCE breaks content

[Netroxen]

Scenarios

Scenario 1

1. Open image dialog in TinyMCE editor

• Default ( Large 768x768 )

2. Go to "Upload" tab

• Select an image from the local disk
• Click "Insert" or "Upload" and then "Insert"

3. Navigate to the image and "Settings" tab

• Select "Exclude from navigation"

4. Navigate back to parent item ( Content-Type the image was inserted on )

• The image is no longer shown, only the filename...

5. Go into edit mode and click "Save" again

• The image is now visible and also excluded from the navigation...

Scenario 2

1. Open image dialog in TinyMCE editor

• Select ( Preview 400x400 )

2. Go to "Upload" tab

• Select an image from the local disk
• Click "Insert" or "Upload" and then "Insert"

3. Navigate to the image and "Settings" tab

• Select "Exclude from navigation"

4. Navigate back to parent item ( Content-Type the image was inserted on )

• This time the image is still shown...

Example

Expected

When inserting an image in the TinyMCE editor, I often want to exclude it from the navigation. However doing this in the current state causes the image to disappear from the content.

1. Open image dialog in TinyMCE editor

• Select any image scale or default

2. Go to "Upload" tab

• Select an image from the local disk
• Click "Insert" or "Upload" and then "Insert"

3. Navigate to the image and "Settings" tab

• Select "Exclude from navigation"

4. Navigate back to parent item ( Content-Type the image was inserted on )

• The image should still be shown...

Versions

Plone 5.1.2.1 (5112)
CMF 2.2.12
Zope 2.13.27
Python 2.7.14 (default, Oct 9 2017, 22:27:46) [GCC 4.8.4]
PIL 4.3.0 (Pillow)

[petschki]

NOTE: this happens every time you edit the image. This is likely due to scale recreation on ObjectEdited event but somehow portal_transform doesn't get the updated scales for the image object?

/cc @davisagli maybe you've got some idea where to fix this?

[petschki]

after some digging on this, the underlying problem is, that plone.app.textfield caches the whole transformed output https://github.com/plone/plone.app.textfield/blob/master/plone/app/textfield/transform.py#L44 ... so the generated urls from plone.scale are outdated if you edit the referenced image afterwards. I'll create a pull request there today to fix this issue ...

[petschki]

fixed by plone/plone.app.textfield#30