From 14d49a8dbea4d322ef2654c107c98cf64b278ab6 Mon Sep 17 00:00:00 2001 From: Donovan Hutchence Date: Mon, 30 May 2022 10:28:32 +0100 Subject: [PATCH 1/2] return original source if preprocessor fails --- src/core/preprocessor.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/preprocessor.js b/src/core/preprocessor.js index 02c5a68c5c4..1e49ffa482d 100644 --- a/src/core/preprocessor.js +++ b/src/core/preprocessor.js @@ -220,7 +220,7 @@ class Preprocessor { if (error) { Debug.error("Failed to preprocess shader: ", { source: originalSource }); - return null; + return originalSource; } return source; From cfecd67ff649d74fb346eff2e537e8e7fcfd6df5 Mon Sep 17 00:00:00 2001 From: Donovan Hutchence Date: Mon, 30 May 2022 15:53:06 +0100 Subject: [PATCH 2/2] make preprocess failure always output warning --- src/core/preprocessor.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/preprocessor.js b/src/core/preprocessor.js index 1e49ffa482d..1280b6b5322 100644 --- a/src/core/preprocessor.js +++ b/src/core/preprocessor.js @@ -219,7 +219,7 @@ class Preprocessor { } if (error) { - Debug.error("Failed to preprocess shader: ", { source: originalSource }); + console.warn("Failed to preprocess shader: ", { source: originalSource }); return originalSource; }