Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiCamera events not handled properly #7136

Open
kungfooman opened this issue Nov 24, 2024 · 2 comments
Open

MultiCamera events not handled properly #7136

kungfooman opened this issue Nov 24, 2024 · 2 comments
Assignees

Comments

@kungfooman
Copy link
Collaborator

Just tested @willeastcott rope bridge: https://engine-c3vj73m56-playcanvas.vercel.app/#/physics/rope-bridge

Not related to it - but it displays the bug:

camera-controls.mjs:668 Uncaught TypeError: Cannot read properties of null (reading 'canvas')
    at CameraControls._look (camera-controls.mjs:668:54)
    at CameraControls._onPointerMove (camera-controls.mjs:540:22)

Every time you restart the example, it's collecting never-deleted events (aka destroy/detach isn't called properly).

image

Orbit example displays same issue.

@kpal81xd
Copy link
Contributor

kpal81xd commented Dec 3, 2024

I cant repro this can you confirm if its still an issue? @kungfooman

@kungfooman
Copy link
Collaborator Author

I just took a Vercel link from 2 hours ago to test: https://engine-o685bw9d0-playcanvas.vercel.app/#/camera/orbit

Definitely still an issue:

  1. Refresh a few times
  2. Orbit the model

Result:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants