Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove energy conservation flag in standard material #4970

Closed
GSterbrant opened this issue Jan 12, 2023 · 0 comments · Fixed by #6756
Closed

Remove energy conservation flag in standard material #4970

GSterbrant opened this issue Jan 12, 2023 · 0 comments · Fixed by #6756
Assignees
@mvaligursky
Labels
area: graphics Graphics related issue

Comments

@GSterbrant
Copy link
Contributor

GSterbrant commented Jan 12, 2023 •
edited
Loading

Description

Energy conservation should be enabled on PBR materials always, so there is no need to keep this flag around. When using phong shading, light conservation code should not be generated in the lit shader.

Relates to #4961.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mvaligursky mvaligursky

Labels
area: graphics Graphics related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BREAKING] Remove energy conservation flag in standard material playcanvas/engine
2 participants
@mvaligursky @GSterbrant