Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camera dropdown list no longer scrolls #821

Closed
brianruggieri opened this issue Jul 7, 2022 · 11 comments
Closed

Camera dropdown list no longer scrolls #821

brianruggieri opened this issue Jul 7, 2022 · 11 comments
Assignees
Labels
area: editor interface bug Something isn't working

Comments

@brianruggieri
Copy link

Description

This may be a bit of an edge case with how my team sets up many cameras in a scene, but a long list of cameras is now limited by the height of the scene view canvas. From what I recall, this list used to scroll. It would be beneficial for us if that functionality was restored.

Screenshots

Screen Shot 2022-07-07 at 7 57 21 AM
Screen Shot 2022-07-07 at 7 57 27 AM

@yaustar yaustar added bug Something isn't working area: editor interface labels Jul 7, 2022
@yaustar
Copy link
Collaborator

yaustar commented Jul 7, 2022

For a short term workaround while we look into this

  • Select the camera in the hierarchy view (ensuring it is enabled)
  • Left click on the camera preview that shows up
  • The Editor View will and Camera selection is now that camera
Kapture.2022-07-07.at.13.11.33.mp4

@jiajasper
Copy link

I like Steven's suggestion, if no camera is selected in hierarchy, "Camera" would not show up in the dropdown.

We also have a ticket regarding using the dockable camera viewport to entire "Camera" view
#795

@yaustar
Copy link
Collaborator

yaustar commented Jul 7, 2022

I like Steven's suggestion, if no camera is selected in hierarchy, "Camera" would not show up in the dropdown.

I didn't make this suggestion 😅 The camera has to be enabled otherwise the editor view doesn't render correctly when the camera is selected

I think it would be better if the editor view did render as though it was enabled as it makes editing/positioning cameras easier without having to enabled/disable cameras

@jiajasper
Copy link

The camera has to be enabled otherwise the editor view doesn't render correctly when the camera is selected

I am not sure what you mean by this, camera entities are enabled, they just do not show up in the dropdown if it is not selected.

@yaustar
Copy link
Collaborator

yaustar commented Jul 7, 2022

Oh wait, you don't want any cameras in the list at all? That's a big UX departure from the current known behaviour now 🤔

@yaustar
Copy link
Collaborator

yaustar commented Jul 7, 2022

I don't think we can do that till with have #262 in place to filter all the cameras in the hierarchy view at least

It's also an extra step to find the camera in the hierarchy view first when now, it's an easy to find list under the view dropdown

@jiajasper
Copy link

jiajasper commented Jul 7, 2022

We can rename "Camera" to "Selected Camera" and make it a generic option (which means that it would not read camera entity's name)

if no camera is selected, the "Selected Camera" option still shows up in the dropdown, but it would be disbled. When hovered over, our tooltip will prompt users to select a camera entity first. Once a camera is select from the hierarchy, then "Selected Camera" option in the dropdown will become enabled to be selected.

PS. I will find some time to mock it out!

@yaustar
Copy link
Collaborator

yaustar commented Jul 7, 2022

@brianruggieri - What do you think about the above proposal as your team is a power user of the current dropdown?

@brianruggieri
Copy link
Author

@yaustar for our use case, I think we like the option of all cameras listed in the separate dropdown to avoid digging through the hierarchy. Ultimately we disable all the cameras in our scene but do typically have them enabled as we set up all these different "views". The amount we use just becomes a problem if that list can't scroll.

Great to know about that workaround. I was not aware of that feature with the camera preview.

@yaustar
Copy link
Collaborator

yaustar commented Jul 27, 2022

@rstander-EL
Copy link

Thank you for fixing that guys

@yaustar yaustar closed this as completed Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: editor interface bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants