Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anim Component doesn't show template overrides #678

Closed
daredevildave opened this issue Feb 1, 2022 · 9 comments
Closed

Anim Component doesn't show template overrides #678

daredevildave opened this issue Feb 1, 2022 · 9 comments
Assignees
Labels

Comments

@daredevildave
Copy link

When using the Anim Component in a template instance, I can't apply changes to the Anim Component to the template.

Differences are visible in the overrides panel at the top (but there is no way to apply them individually, only "apply all".

The Anim Component interface doesn't show overrides to the template.

@yaustar
Copy link
Collaborator

yaustar commented Feb 1, 2022

Confirmed in a new project

https://playcanvas.com/project/877189/overview/anim-component-template-bug

Kapture.2022-02-01.at.16.51.47.mp4

@yaustar
Copy link
Collaborator

yaustar commented Feb 1, 2022

@daredevildave Just to check, are you saying 'apply all' works? And also, are there specific anim component values that can't be applied individually or is it any of the properties?

@daredevildave
Copy link
Author

Exactly. In my case I had changes to the Anim Component and changes to the Script Component, but I couldn't apply on the Anim Component changes. The Script Component had a blue highlight and I could right-click to apply the changes. The Anim Component did not.

I mentioned that in case I had missed some UI in the design which let me use the template interface at the top of the sidebar (as pictured above) to apply changes component by component. I could only see a button to apply all changes.

@willeastcott
Copy link
Contributor

Looks like a fix was just merged for this by @zachpeterpaul. We'll aim to deploy within a day or so.

@yaustar
Copy link
Collaborator

yaustar commented Feb 1, 2022

@daredevildave Sorry, just want to make sure that I'm looking at the right issue: no matter what parameter/attribute was changed on the anim component, you couldn't apply individually. Or was it a specific one that didn't show up in the diff?

@daredevildave
Copy link
Author

No changes to the anim component show up as diffs either in the component interface or in the template "view diffs" interface in the sidebar.

I do see the "total" number of differences in the template interface at the top of the side bar.

@daredevildave
Copy link
Author

Screenshot 2022-02-01 at 3 21 18 PM

Screenshot 2022-02-01 at 3 22 07 PM

@yaustar
Copy link
Collaborator

yaustar commented Feb 1, 2022

That's really weird. If the issue is still there, can you make a fork of the project please and add 'yaustar' to the team and I take a look tomorrow?

@willeastcott willeastcott reopened this Feb 1, 2022
@daredevildave
Copy link
Author

I believe this is fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants