From 12df1ce03ef5985af19cdffa4ec70df659bf3b6f Mon Sep 17 00:00:00 2001 From: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Date: Sun, 5 Mar 2023 17:31:30 +0200 Subject: [PATCH] test deferred till https://github.com/vitessio/vitess/pull/12147 is merged Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> --- go/vt/schemadiff/schema_diff_test.go | 27 ++++++++++++++------------- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/go/vt/schemadiff/schema_diff_test.go b/go/vt/schemadiff/schema_diff_test.go index 818a6622402..6ab99658356 100644 --- a/go/vt/schemadiff/schema_diff_test.go +++ b/go/vt/schemadiff/schema_diff_test.go @@ -257,18 +257,19 @@ func TestSchemaDiff(t *testing.T) { expectDeps: 1, entityOrder: []string{"t2", "v2"}, }, - { - name: "alter view (2 tables), alter tables", - toQueries: []string{ - "create table t1 (id int primary key, info int not null, dt datetime);", - "create table t2 (id int primary key, ts timestamp, v varchar);", - "create view v1 as select id from t1", - "create view v2 as select info, v from t1, t2", - }, - expectDiffs: 3, - expectDeps: 2, - entityOrder: []string{"t1", "t2", "v2"}, - }, + // { + // // This will become relevant when https://github.com/vitessio/vitess/pull/12147 is merged + // name: "alter view (2 tables), alter tables", + // toQueries: []string{ + // "create table t1 (id int primary key, info int not null, dt datetime);", + // "create table t2 (id int primary key, ts timestamp, v varchar);", + // "create view v1 as select id from t1", + // "create view v2 as select info, v from t1, t2", + // }, + // expectDiffs: 3, + // expectDeps: 2, + // entityOrder: []string{"t1", "t2", "v2"}, + // }, { name: "drop view", toQueries: []string{ @@ -354,7 +355,7 @@ func TestSchemaDiff(t *testing.T) { entityOrder: []string{"t2", "v1", "v2"}, }, // { - // // This will become relevant when https://github.com/vitessio/vitess/issues/12147 is merged + // // This will become relevant when https://github.com/vitessio/vitess/pull/12147 is merged // name: "alter table, alter view, impossible sequence", // fromQueries: []string{ // "create table t1 (id int primary key, info int not null);",