Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create connection should not log the password #7

Closed
dstockhammer opened this issue May 2, 2024 · 0 comments · Fixed by #8
Closed

Create connection should not log the password #7

dstockhammer opened this issue May 2, 2024 · 0 comments · Fixed by #8

Comments

@dstockhammer
Copy link
Contributor

Hey there,

I think MySqlConnector::createConnection should not log the password, even if it's just a short-lived token. For debugging purposes I suppose one could add a message about the DB and authentication method.

Furthermore, I think INFO is too verbose for this. DEBUG would be more appropriate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change MySqlConnector log level to DEBUG and remove password
1 participant
@dstockhammer