Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't print out empty intersections #290

Open
elshize opened this issue Nov 27, 2019 · 0 comments
Open

Don't print out empty intersections #290

elshize opened this issue Nov 27, 2019 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers priority:low

Comments

@elshize
Copy link
Member

elshize commented Nov 27, 2019

Currently, compute_intersection with --combinations prints out all combinations, even empty ones. We should add a condition that doesn't print out an intersection if intersection.length == 0 because it means effectively it doesn't exist, and it could create problems later on.
@elshize elshize added the bug Something isn't working label Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers priority:low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@elshize