Live block computation

[amallia]

Describe the bug

pisa/test/test_wand_data.cpp

Line 108 in f8c65c1

for (int i = 0; i < live_blocks.size(); ++i) {

Local variable i shadows outer variable.

[wanghenshui]

set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wextra")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wsign-compare")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wshadow")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wunused-parameter")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror")

may helpful

[elshize]

@wanghenshui I'm all for extensive warnings, but do you have any idea if we can suppress warnings in the header-only libraries we depend on?

[wanghenshui]

suppress warnings in the header

https://stackoverflow.com/questions/1867065/how-to-suppress-gcc-warnings-from-library-headers

// save diagnostic state
#pragma GCC diagnostic push 

// turn off the specific warning. Can also use "-Wall"
#pragma GCC diagnostic ignored "-Wunused-but-set-variable"

#include <boost/uuid/uuid.hpp>
#include <boost/uuid/uuid_generators.hpp>
#include <boost/uuid/uuid_io.hpp>
#include <boost/lexical_cast.hpp>

// turn the warnings back on
#pragma GCC diagnostic pop