Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

From-Scratch docker image + Documentation #225

Open
Arteneko opened this issue Jul 16, 2019 · 1 comment
Open

From-Scratch docker image + Documentation #225

Arteneko opened this issue Jul 16, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@Arteneko
Copy link

Looking at some old issues (the two that can be found when searching for Dockerfile), it appears that pisa may already have a docker image in some registry.

If so, documentation, or at least a link to this registry's image page, should be added.

If not, it'd be nice to have a from-scratch docker image.

@Arteneko Arteneko added the enhancement New feature or request label Jul 16, 2019
@amallia
Copy link
Member

amallia commented Jul 16, 2019

Thank you @IvanDelsinne for opening this issue.
Pisa has a Docker image https://github.com/pisa-engine/docker, which still need to be improved.
Currently the binaries are built when the Docker image is built. It would be nice to build the binaries in the machine where the Docker is running, because otherwise the binaries are not optimized for the architecture.

In the meantime, do you want to open a PR for the documentation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants