From d4aaf810f11af87c7b8e4ef7bc4788d7b4e28a71 Mon Sep 17 00:00:00 2001 From: Weizhen Wang Date: Tue, 6 Dec 2022 17:00:59 +0800 Subject: [PATCH 1/2] *: fix revive false positive with generics Signed-off-by: Weizhen Wang --- build/linter/allrevive/analyzer.go | 2 ++ tools/check/revive.toml | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/build/linter/allrevive/analyzer.go b/build/linter/allrevive/analyzer.go index efdccf67d21a7..676fe038b0d3f 100644 --- a/build/linter/allrevive/analyzer.go +++ b/build/linter/allrevive/analyzer.go @@ -65,6 +65,7 @@ var defaultRules = []lint.Rule{ &rule.TimeNamingRule{}, //&rule.ContextKeysType{}, &rule.ContextAsArgumentRule{}, + &rule.ReceiverNamingRule{}, } var allRules = append([]lint.Rule{ @@ -118,6 +119,7 @@ var allRules = append([]lint.Rule{ &rule.TimeEqualRule{}, //&rule.BannedCharsRule{}, &rule.OptimizeOperandsOrderRule{}, + &rule.ReceiverNamingRule{}, }, defaultRules...) func run(pass *analysis.Pass) (any, error) { diff --git a/tools/check/revive.toml b/tools/check/revive.toml index aec448993d8e2..59c0fa9ba1710 100644 --- a/tools/check/revive.toml +++ b/tools/check/revive.toml @@ -29,7 +29,7 @@ warningCode = -1 [rule.var-naming] [rule.package-comments] [rule.range] -[rule.receiver-naming] +#[rule.receiver-naming] [rule.indent-error-flow] [rule.superfluous-else] [rule.modifies-parameter] From 42500b0e851cd976c675fad262266135bd231512 Mon Sep 17 00:00:00 2001 From: Weizhen Wang Date: Tue, 6 Dec 2022 17:04:00 +0800 Subject: [PATCH 2/2] *: fix revive false positive with generics Signed-off-by: Weizhen Wang --- build/linter/allrevive/analyzer.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/build/linter/allrevive/analyzer.go b/build/linter/allrevive/analyzer.go index 676fe038b0d3f..efdccf67d21a7 100644 --- a/build/linter/allrevive/analyzer.go +++ b/build/linter/allrevive/analyzer.go @@ -65,7 +65,6 @@ var defaultRules = []lint.Rule{ &rule.TimeNamingRule{}, //&rule.ContextKeysType{}, &rule.ContextAsArgumentRule{}, - &rule.ReceiverNamingRule{}, } var allRules = append([]lint.Rule{ @@ -119,7 +118,6 @@ var allRules = append([]lint.Rule{ &rule.TimeEqualRule{}, //&rule.BannedCharsRule{}, &rule.OptimizeOperandsOrderRule{}, - &rule.ReceiverNamingRule{}, }, defaultRules...) func run(pass *analysis.Pass) (any, error) {