planner: freeze the output order of UPDATE's select #13166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#13208 Would fix the failed unit test this pr meets. |
Codecov Report
@@ Coverage Diff @@
## master #13166 +/- ##
===========================================
Coverage 80.1737% 80.1737%
===========================================
Files 469 469
Lines 112548 112548
===========================================
Hits 90234 90234
Misses 15320 15320
Partials 6994 6994 |
|
Your auto merge job has been accepted, waiting for 13354, 13209 |
|
/run-all-tests |
|
@winoros merge failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Join reorder may be applied in optimization and cause the columns' output order changed.
The added test would panic then.
What is changed and how it works?
Add a projection to freeze the output order.
Check List
Tests
Release note