Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests requiring autoAnalyze disabled should assert it is disabled #34792

Open
morgo opened this issue May 18, 2022 · 0 comments
Open

Tests requiring autoAnalyze disabled should assert it is disabled #34792

morgo opened this issue May 18, 2022 · 0 comments
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@morgo
Copy link
Contributor

morgo commented May 18, 2022

Enhancement

Forked from #34643

In the tests that require AutoAnalyze disabled, we should potentially assert that it is infact disabled. i.e.

require.Equal(variable.RunAutoAnalyze.Load(), false)

Another potential fix is to make setting atomics outside of system variables more stable. Currently changes are reverted when the SetGlobal func is called in the sysvar cache.

@morgo morgo added the type/enhancement The issue or PR belongs to an enhancement. label May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

No branches or pull requests

1 participant