Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support GBK for builtin function lower #28360

Closed
Tracked by #26816
zimulala opened this issue Sep 26, 2021 · 3 comments · Fixed by #28869
Closed
Tracked by #26816

Support GBK for builtin function lower #28360

zimulala opened this issue Sep 26, 2021 · 3 comments · Fixed by #28869
Assignees
@Defined2014
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@zimulala
Copy link
Contributor

No description provided.

@zimulala zimulala mentioned this issue Sep 26, 2021
Closed
16 tasks
@zimulala zimulala added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Sep 26, 2021
@Defined2014
Copy link
Contributor

/assign

@xiongjiwei
Copy link
Contributor

seems no need to work on this function, we store gbk data with utf8 encoding, the current code (upperUTF8) is enough to handle the gbk character.

@Defined2014
Copy link
Contributor

seems no need to work on this function, we store gbk data with utf8 encoding, the current code (upperUTF8) is enough to handle the gbk character.

It has different behavior in MySQL, so I think we need a different function to do that.
https://dev.mysql.com/worklog/task/?id=4583

@Defined2014 Defined2014 mentioned this issue Oct 15, 2021
Merged
4 tasks
@xiongjiwei xiongjiwei mentioned this issue Nov 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Defined2014 Defined2014

Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

expression, parser: support GBK charset for builtin function lower() Defined2014/tidb
3 participants
@zimulala @Defined2014 @xiongjiwei