Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate test-infra to testify for util/admin pkg #26102

Closed
Tracked by #33453
tisonkun opened this issue Jul 10, 2021 · 4 comments · Fixed by #26318
Closed
Tracked by #33453

migrate test-infra to testify for util/admin pkg #26102

tisonkun opened this issue Jul 10, 2021 · 4 comments · Fixed by #26318
Assignees

Comments

@tisonkun
Copy link
Contributor

No description provided.

@evilbinary
Copy link
Contributor

Hi @tisonkun, I'd like to migrate tests under util/admin pkg. Please create a subtask and assign to me.

@tisonkun
Copy link
Contributor Author

/assign @evilbinary

Glad to see your interest @evilbinary ! That is the subtask and I will assign it to you.

@jyz0309
Copy link
Contributor

jyz0309 commented Jul 13, 2021

Hello~ @evilbinary
I notice that the admin_integration_test.go have used a lot of testKit.MustExec(). And we have not implemented another testkit yet. So I think you can migrate test-infra to testify for admin_test.go first.
What do you think? @tisonkun

@tisonkun
Copy link
Contributor Author

Yep. That makes sense. Besides, we shall make the first migration of testkit.TestKit example asap :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants