Revoke does not correctly populate the dynamic privilege name

[morgo]

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

With dynamic privileges the "grant option" is per privilege and not global. This is correctly handled in GRANT, but not in REVOKE.

If there a no-non dynamic privileges being revoked, then the global grant option should not be required:

tidb/planner/core/planbuilder.go

Line 2271 in adfe029

vi = appendVisitInfo(vi, mysql.GrantPriv, dbName, tableName, "", nil)

This bug was introduced in the new feature in #22778 ; and does not affect any current released versions.

[cosven]

/severity moderate

[ti-srebot]

Please edit this comment or add a new comment to complete the following information

Bug

Revoke did not work correctly with dynamic privileges.

1. Root Cause Analysis (RCA) (optional)

2. Symptom (optional)

3. All Trigger Conditions (optional)

4. Workaround (optional)

5. Affected versions

unreleased

6. Fixed versions

master