Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a better cache strategy for statements_summary #24085

Open
Tracked by #24086
crazycs520 opened this issue Apr 16, 2021 · 0 comments
Open
Tracked by #24086

Use a better cache strategy for statements_summary #24085

crazycs520 opened this issue Apr 16, 2021 · 0 comments
Labels
type/feature-request Categorizes issue or PR as related to a new feature.

Comments

@crazycs520
Copy link
Contributor

Feature Request

Is your feature request related to a problem? Please describe:

Currently, statements_summary_history use LRU cache strategy to cache recent 200 statements and each statement with 24 histories by default.

The problem is, the history statements can be evicted by the new statement, so the variable tidb_stmt_summary_history_size (which default value is 24) doesn't mean STATEMENTS_SUMMARY_HISTORY can alway provide the last 24 statements history.

I hope we can find another cache strategy for statements_summary and also don't have to pay too much memory.

Describe the feature you'd like:

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

@crazycs520 crazycs520 added the type/feature-request Categorizes issue or PR as related to a new feature. label Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature-request Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

1 participant