From 710b1d28df9c42454cfb4703bcfd47637d5fd8dd Mon Sep 17 00:00:00 2001 From: Fullstop000 Date: Mon, 11 Nov 2019 17:04:50 +0800 Subject: [PATCH] expression: add setPbCode for Sign Sqrt Signed-off-by: Fullstop000 --- expression/builtin_math.go | 2 ++ expression/builtin_math_test.go | 3 +++ 2 files changed, 5 insertions(+) diff --git a/expression/builtin_math.go b/expression/builtin_math.go index 91ffdc16c7757..931898de73a0b 100644 --- a/expression/builtin_math.go +++ b/expression/builtin_math.go @@ -1233,6 +1233,7 @@ func (c *signFunctionClass) getFunction(ctx sessionctx.Context, args []Expressio } bf := newBaseBuiltinFuncWithTp(ctx, args, types.ETInt, types.ETReal) sig := &builtinSignSig{bf} + sig.setPbCode(tipb.ScalarFuncSig_Sign) return sig, nil } @@ -1272,6 +1273,7 @@ func (c *sqrtFunctionClass) getFunction(ctx sessionctx.Context, args []Expressio } bf := newBaseBuiltinFuncWithTp(ctx, args, types.ETReal, types.ETReal) sig := &builtinSqrtSig{bf} + sig.setPbCode(tipb.ScalarFuncSig_Sqrt) return sig, nil } diff --git a/expression/builtin_math_test.go b/expression/builtin_math_test.go index 94f2246ce4213..ae67db0138fce 100644 --- a/expression/builtin_math_test.go +++ b/expression/builtin_math_test.go @@ -14,6 +14,7 @@ package expression import ( + "github.com/pingcap/tipb/go-tipb" "math" "math/rand" "runtime" @@ -602,6 +603,7 @@ func (s *testEvaluatorSuite) TestSign(c *C) { fc := funcs[ast.Sign] f, err := fc.getFunction(s.ctx, s.primitiveValsToConstants(t.num)) c.Assert(err, IsNil, Commentf("%v", t)) + c.Assert(f.PbCode(), Equals, tipb.ScalarFuncSig_Sign) v, err := evalBuiltinFunc(f, chunk.Row{}) c.Assert(err, IsNil, Commentf("%v", t)) c.Assert(v, testutil.DatumEquals, types.NewDatum(t.ret), Commentf("%v", t)) @@ -665,6 +667,7 @@ func (s *testEvaluatorSuite) TestSqrt(c *C) { fc := funcs[ast.Sqrt] f, err := fc.getFunction(s.ctx, s.primitiveValsToConstants(t.Arg)) c.Assert(err, IsNil) + c.Assert(f.PbCode(), Equals, tipb.ScalarFuncSig_Sqrt) v, err := evalBuiltinFunc(f, chunk.Row{}) c.Assert(err, IsNil) c.Assert(v, testutil.DatumEquals, types.NewDatum(t.Ret), Commentf("%v", t))