small fix

lidezhu · lidezhu · commit c9dbadfcb17c · 2024-10-14T22:32:36.000+08:00
diff --git a/logservice/eventstore/event_store.go b/logservice/eventstore/event_store.go
@@ -166,7 +166,7 @@ func New(
 ) EventStore {
 	clientConfig := &logpuller.SubscriptionClientConfig{
 		RegionRequestWorkerPerStore:   16,
-		ChangeEventProcessorNum:       32,
+		ChangeEventProcessorNum:       64,
 		AdvanceResolvedTsIntervalInMs: 600,
 	}
 	client := logpuller.NewSubscriptionClient(
diff --git a/logservice/schemastore/persist_storage.go b/logservice/schemastore/persist_storage.go
@@ -292,6 +292,7 @@ func (p *persistentStorage) getTableInfo(tableID int64, ts uint64) (*common.Tabl
 	return store.getTableInfo(ts)
 }
 
+// TODO: this may consider some shouldn't be send ddl, like create table, does it matter?
 func (p *persistentStorage) getMaxEventCommitTs(tableID int64, ts uint64) uint64 {
 	p.mu.RLock()
 	defer p.mu.RUnlock()

Original file line number	Diff line number	Diff line change
`@@ -166,7 +166,7 @@ func New(`
`166`	`166`	`) EventStore {`
`167`	`167`	`clientConfig := &logpuller.SubscriptionClientConfig{`
`168`	`168`	`RegionRequestWorkerPerStore: 16,`
`169`		`- ChangeEventProcessorNum: 32,`
	`169`	`+ ChangeEventProcessorNum: 64,`
`170`	`170`	`AdvanceResolvedTsIntervalInMs: 600,`
`171`	`171`	`}`
`172`	`172`	`client := logpuller.NewSubscriptionClient(`
Original file line number	Diff line number	Diff line change
`@@ -292,6 +292,7 @@ func (p persistentStorage) getTableInfo(tableID int64, ts uint64) (common.Tabl`
`292`	`292`	`return store.getTableInfo(ts)`
`293`	`293`	`}`
`294`	`294`
	`295`	`+// TODO: this may consider some shouldn't be send ddl, like create table, does it matter?`
`295`	`296`	`func (p *persistentStorage) getMaxEventCommitTs(tableID int64, ts uint64) uint64 {`
`296`	`297`	`p.mu.RLock()`
`297`	`298`	`defer p.mu.RUnlock()`