Skip to content

Commit 440c439

Browse files
committed
fix schema store lag
1 parent 3deccca commit 440c439

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

logservice/schemastore/schema_store.go

+7-4
Original file line numberDiff line numberDiff line change
@@ -137,6 +137,13 @@ func (s *schemaStore) Close(ctx context.Context) error {
137137
func (s *schemaStore) updateResolvedTsPeriodically(ctx context.Context) error {
138138
tryUpdateResolvedTs := func() {
139139
pendingTs := s.pendingResolvedTs.Load()
140+
defer func() {
141+
currentPhyTs := oracle.GetPhysical(s.pdClock.CurrentTime())
142+
resolvedPhyTs := oracle.ExtractPhysical(pendingTs)
143+
resolvedLag := float64(currentPhyTs-resolvedPhyTs) / 1e3
144+
metrics.SchemaStoreResolvedTsLagGauge.Set(float64(resolvedLag))
145+
}()
146+
140147
if pendingTs <= s.resolvedTs.Load() {
141148
return
142149
}
@@ -180,10 +187,6 @@ func (s *schemaStore) updateResolvedTsPeriodically(ctx context.Context) error {
180187
// so we can only update resolved ts after all ddl jobs are written to disk
181188
// Can we optimize it to update resolved ts more eagerly?
182189
s.resolvedTs.Store(pendingTs)
183-
currentPhyTs := oracle.GetPhysical(s.pdClock.CurrentTime())
184-
resolvedPhyTs := oracle.ExtractPhysical(pendingTs)
185-
resolvedLag := float64(currentPhyTs-resolvedPhyTs) / 1e3
186-
metrics.SchemaStoreResolvedTsLagGauge.Set(float64(resolvedLag))
187190
s.dataStorage.updateUpperBound(UpperBoundMeta{
188191
FinishedDDLTs: s.finishedDDLTs,
189192
SchemaVersion: s.schemaVersion,

0 commit comments

Comments
 (0)