From 700a0b52625552514c7c08cada9e74708588c761 Mon Sep 17 00:00:00 2001 From: lance6716 Date: Mon, 18 Oct 2021 14:34:18 +0800 Subject: [PATCH] address comment --- relay/relay.go | 2 +- tests/new_relay/run.sh | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/relay/relay.go b/relay/relay.go index 901ef95c7..db40f900c 100644 --- a/relay/relay.go +++ b/relay/relay.go @@ -128,7 +128,7 @@ func NewRealRelay(cfg *Config) Process { } // Init implements the dm.Unit interface. -// NOTE these errors will make DM-worker exit when it boots up and assigned relay. +// NOTE when Init encounters an error, it will make DM-worker exit when it boots up and assigned relay. func (r *Relay) Init(ctx context.Context) (err error) { return reportRelayLogSpaceInBackground(ctx, r.cfg.RelayDir) } diff --git a/tests/new_relay/run.sh b/tests/new_relay/run.sh index 0482d8a2b..e25fff145 100755 --- a/tests/new_relay/run.sh +++ b/tests/new_relay/run.sh @@ -34,8 +34,6 @@ function test_cant_dail_upstream() { # make sure DM-worker doesn't exit sleep 2 - check_rpc_alive $cur/../bin/check_worker_online 127.0.0.1:$WORKER1_PORT - run_dm_ctl_with_retry $WORK_DIR "127.0.0.1:$MASTER_PORT" \ "query-status -s $SOURCE_ID1" \ "injected error" 1