You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The first big problem is the untagged enum used for backends (#295 (comment)). This leads to unprecise and hard-to-debug errors like #333. By using an adjacently-tagged enum we avoid the parser to "guess" the right config variant and get better error messages, but we break the config API.
The second problem is that options have been added on the fly since the beginning, and most of them are misplaced. We need to make the API more consistent by grouping options by context. Also some namings are not the best. default_page_size is a good (bad?) example: default_ is not need since it is implied by the config itself, and we miss the context (listing).
The text was updated successfully, but these errors were encountered:
soywod
changed the title
Refactor the config file to make it more intuitive and structured.
Refactor the config file to make it more intuitive and structured
Mar 14, 2022
The first big problem is the untagged enum used for backends (#295 (comment)). This leads to unprecise and hard-to-debug errors like #333. By using an adjacently-tagged enum we avoid the parser to "guess" the right config variant and get better error messages, but we break the config API.
The second problem is that options have been added on the fly since the beginning, and most of them are misplaced. We need to make the API more consistent by grouping options by context. Also some namings are not the best.
default_page_size
is a good (bad?) example:default_
is not need since it is implied by the config itself, and we miss the context (listing).The text was updated successfully, but these errors were encountered: