update handlebars@4.5.1 #184
Conversation
|
It looks like 4.4.5 also fixes the security vulnerability. Would a smaller version jump be preferred? |
|
It would only really make a difference if perhaps that would mean we could make a patch release here to reach more people than a minor release. But if either one requires a minor bump of this module it probably makes no difference. |
|
something new ??? |
| @@ -1,3 +1,16 @@ | |||
| 4.1.0 / 2019-11-04 | |||
There was a problem hiding this comment.
This should just be the word "unreleased" and have the ===== separator below it. The version number and date will get populated on publish.
|
|
||
| * deps: handlebars@4.5.1 | ||
| - Add method Handlebars.parseWithoutProcessing | ||
| - Add guard to if & unless helpers |
There was a problem hiding this comment.
It's not clear what this would mean to users of hbs. Is this just an internal change to handebars that users cannot see? If so, you don't need to list it, if not, please expand on what the change means
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "name": "hbs", | |||
| "description": "Express.js template engine plugin for Handlebars", | |||
| "version": "4.0.6", | |||
| "version": "4.1.0", | |||
There was a problem hiding this comment.
You don't actually bump the version in the PR; the release process npm version minor will do the bump and tagging.
| - Bugfix: Contents of raw-blocks must be matched with non-eager regex-matching | ||
| - Bugfix: prevent zero length tokens in raw-blocks | ||
| - Add missing type fields to AST typings | ||
| - Error message for syntax error missing location in 4.2.1+ |
There was a problem hiding this comment.
This module never let this bug through, as we worked around the issue until handbars fixed it. So probably not a change users would see fixed in the upgrade from hbs 4.0.6
| - Bugfix: Use objects for hash value tracking | ||
| - Bugfix: Contents of raw-blocks must be matched with non-eager regex-matching | ||
| - Bugfix: prevent zero length tokens in raw-blocks | ||
| - Add missing type fields to AST typings |
There was a problem hiding this comment.
Not sure what this means, can you elaborate?
fix security advisory
see https://www.npmjs.com/advisories/1300