-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
module name in go.mod for v2 #39
Comments
This leads to more changes and seems incompatible if imported by projects without module enabled. The root cause is because the revision number is not considered with semantic versioning in mind. 😂 I found a simple solution with the following line in
|
If you want the latest updates, v2.1.0 does incorporate them.
The go.mod file was setup this way so as not to upset packages that are not modules aware yet. |
I realize this was closed but I came here intending to file an issue with the same request and then found this. Can I request that, although you're looking at backwards compat now, in the Go 1.14 timeframe (at which point only 1.12-1.14 will be supported, and thus all supported versions support modules) you make this change? |
Hello, I am definitely in favor of doing this change and following the modules naming convention. However, this has to not clash with the usage of this package by users, so would need to consider it when getting to the 1.14 timeframe. Keeping this issue open as a reminder. |
As noted in #33 (comment), the current approach — a The fact that it appears to work at all today is due to a bug (golang/go#32695), which I am planning to fix for Go 1.13. |
Thanks for the heads up. I agree that it is currently wrong and should be fixed. Need to think about the best way to not upset the packages importing this package though. |
For a short-term fix, you could simply remove the For the longer term, see http://golang.org/wiki/Modules#releasing-modules-v2-or-higher for some more in-depth discussion. |
Removed support for modules in version 2. |
It should have v2 in
go.mod
and then this example works,
The text was updated successfully, but these errors were encountered: