Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce project specific settings #50

Open
noxan opened this issue Jun 1, 2018 · 2 comments
Open

Introduce project specific settings #50

noxan opened this issue Jun 1, 2018 · 2 comments

Comments

@noxan
Copy link
Contributor

noxan commented Jun 1, 2018

Look for config file within the current directory or traverse up to some root settings. The git location could be a good root folder.

@lhnrd
Copy link
Contributor

lhnrd commented Jun 2, 2018

Can you elaborate more on how it will look like?

I can think of:

  • .gi.yaml on project root, without the token.
  • "gi" property on package.json.

We already have this .gi.yaml config file for authentication, I guess it's not ideal to use it for project settings too right? Since users can choose to commit the settings file.

@noxan
Copy link
Contributor Author

noxan commented Jul 13, 2018

I would imagine the configuration to work the same on all levels, but the more local settings override the global ones. How this exactly withs with package.json versus project root I am not sure. But maybe we all only in package.json in the first place.

Not combining it with the authentication sounds reasonable. Maybe best would be to move the authentication somewhere else with a deprecation (analog to .npmrc).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants