Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inspection for builder class methods' called with their default values #1

Closed
picimako opened this issue Feb 14, 2022 · 1 comment
Closed

Inspection for builder class methods' called with their default values #1

picimako opened this issue Feb 14, 2022 · 1 comment
Assignees
@picimako
Labels
feature New functionality
Milestone
v1.0.2

Comments

@picimako
Copy link
Owner

picimako commented Feb 14, 2022 •
edited
Loading

Summary

There are a couple of builder classes in WireMock whose certain fields have default values.

Tasks

  • Create an inspection that, where possible, would report calls to such builder methods with their default values.
  • One such examples is WireMockExtension.options() with the WireMockConfiguration.wireMockConfig().dynamicPort(); default value.
  • Other related classes:
    • com.github.tomakehurst.wiremock.matching.MultipartValuePatternBuilder
    • com.github.tomakehurst.wiremock.matching.RequestPatternBuilder
    • com.github.tomakehurst.wiremock.client.ResponseDefinitionBuilder
    • com.github.tomakehurst.wiremock.recording.RecordSpecBuilder
    • com.github.tomakehurst.wiremock.core.WireMockConfiguration
    • com.github.tomakehurst.wiremock.client.WireMockBuilder
@picimako picimako added the feature New functionality label Feb 14, 2022
@picimako picimako added this to the v1.0.2 milestone Apr 4, 2022
@picimako picimako changed the title Inspection for default WireMockExtension options configuration Inspection for builder class methods' called with their default values Apr 14, 2022
@picimako picimako self-assigned this May 1, 2022
@picimako
Copy link
Owner Author

picimako commented May 4, 2022

Completed in v1.0.2.

@picimako picimako closed this as completed May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@picimako picimako

Labels
feature New functionality
Projects
None yet
Milestone
v1.0.2
Development

No branches or pull requests
1 participant
@picimako