Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for json index methods in Package_PHP_Web #177

Open
lhsazevedo opened this issue Nov 3, 2024 · 5 comments
Open

Add unit tests for json index methods in Package_PHP_Web #177

lhsazevedo opened this issue Nov 3, 2024 · 5 comments
Assignees

Comments

@lhsazevedo
Copy link
Contributor

This issue is specifically to add the first unit tests for the Package_PHP_Web class, which currently have no test coverage, focusing on the writeJsonIndex and processJsonIndex methods.

A follow-up issue should be created to address unit tests for the remaining methods.

@lhsazevedo
Copy link
Contributor Author

@haszi Please assign me

@lhsazevedo
Copy link
Contributor Author

Context: #160 (review)

@lhsazevedo
Copy link
Contributor Author

Hi @haszi

I declared these methods as private, which makes it a bit tricky to hook into them using the existing approach of extending classes (i.e. Test*.php classes in phpdotnet/phd).

Would it be okay to extract this JSON index behavior into a dedicated class and just test it directly? Or would you prefer that I find a way to maintain the current strategy of test subject extension?

@lhsazevedo
Copy link
Contributor Author

ping @haszi @Girgias

@Girgias
Copy link
Member

Girgias commented Jan 30, 2025

Sorry, I think extracting the index into a dedicated class makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants