-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to force composer audit to rely non-dynamic TUF-protectable resources #99
Comments
If it's possible, I heartily and vigorously suggest we do NOT do this. Essentially disabling the ability to audit would thoroughly undermine our mission and shatter any credibility we have. I think it is more valuable, from an end-user security perspective, to allow auditing without TUF, than it is to forbid auditing because it cannot be protected by TUF. |
And since you ask, Composer uses So in a TUF-protected repository, theoretically we could always force security advisories to be loaded from signed data, rather than from an API. |
@phenaproxima that is why I put 4
I believe that Composer audit is not dependent on these dynamic calls rather it can use the information in each package about security advisories.see https://packages.drupal.org/files/packages/8/p2/drupal/webform.json and the But looking at \Composer\Repository\ComposerRepository::getSecurityAdvisories() it appears that it is possible to use tge info in the individual package instead but I am not sure in what circumstances. |
Related to the drupal.org I mentioned above and related to any repository implementation that wants to implement TUF, does it actually make sense for those repos not to provide the
|
Brought this issue up on a composer issue composer/composer#10329 |
The Packagist API allows providing a URl to dynamically fetching security advisories. https://packagist.org/apidoc#list-security-advisories. I believe this is used by Composer Audit
From a TUF perspective this is not good because the dynamic nature of the possible query arguments probably makes it impossible to protect as a TUF resource.
We should determine if it possible to make
composer audit
rely on resources that can be TUF protectedaudit
and any other Composer operation fallback to using the security advisories in the .json files for packages? Is this the same information in just different form?related drupal.org issue https://www.drupal.org/project/project_composer/issues/3301876
The text was updated successfully, but these errors were encountered: