Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional drivers #32

Closed
bendavies opened this issue Mar 29, 2017 · 2 comments
Closed

Additional drivers #32

bendavies opened this issue Mar 29, 2017 · 2 comments

Comments

@bendavies
Copy link
Contributor

Hey!

This library looks awesome, nice work!
I'd really like to use it to replace our existing implementation, but we currently use SQS and a database as Transports. Are there any plans to support SQS/Database as Transports in enqueue, or would PR's be considered?

Thanks!

@makasim
Copy link
Member

makasim commented Mar 30, 2017

There is a plan but to be honest I would not expect it any time soon. We use RabbitMQ via AMQP so there is no need for SQS at the moment. If we find a customer who needs Enqueue and SQS we certainly add it.

The database transport could be taken from here https://github.com/orocrm/OroMessageQueueComponent/tree/master/Transport/Dbal. It has to be adjusted but at least no need to write it from scratch.

Of course you can work on a PR (I'd very happy to merge it) or you can create a standalone extension (I am fine with it too).

@makasim
Copy link
Member

makasim commented Mar 30, 2017

@bendavies In dbal transport we tried to support delivery guaranty (If a consumer fails the message is get back to the queue and marked redelivered).

That was hardest part. The currently visible solution is no go solution. It simply returns messages to queue after some period of time 2 minutes. So if a consumer takes more that that time to process a message you are in trouble.

We worked on another more sophisticated solution but they have not even merged that to master yet.

I would suggest to completely drop the support of the feature for DBAL transport. It makes it simpler, less deadlocks, better performance and so on.

This was referenced Apr 21, 2017
@makasim makasim closed this as completed Apr 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants