From b179416bb5eada76ecd0aa05fa8e68dc1e77c327 Mon Sep 17 00:00:00 2001 From: Philip Guyton <philip@yewtreeapps.com> Date: Sat, 3 Jun 2023 10:43:37 +0100 Subject: [PATCH] fix services page - Python 3 style sorted() #2564 "cmp" sorted parameter and buildin function dropped in Python 3. --- src/rockstor/smart_manager/views/base_service.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/rockstor/smart_manager/views/base_service.py b/src/rockstor/smart_manager/views/base_service.py index b8f6ed5ed..0ec5d4fed 100644 --- a/src/rockstor/smart_manager/views/base_service.py +++ b/src/rockstor/smart_manager/views/base_service.py @@ -90,9 +90,8 @@ def get_queryset(self, *args, **kwargs): sos = [] for s in Service.objects.all(): sos.append(self._get_or_create_sso(s)) - return sorted( - sos, cmp=lambda x, y: cmp(x.display_name, y.display_name) - ) # noqa + # https://docs.python.org/3.6/howto/sorting.html#key-functions + return sorted(sos, key=lambda each: each.display_name) class BaseServiceDetailView(ServiceMixin, rfc.GenericView):