Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: save Export to io.Writer and Import from io.Reader #70

Closed
erikdubbelboer opened this issue Apr 27, 2024 · 6 comments
Closed

Comments

@erikdubbelboer
Copy link
Contributor

Currently Export and Import use files. It would be nicer if we have versions with io.Writer and io.Reader so we can use other data sources such as S3 or HTTP requests.

@philippgille
Copy link
Owner

Yup, makes sense!

Do you have in mind more something like db.Export(myWriter) where the user can / has to add compression and encryption by himself, or more db.Export(myWriter, true, "mySecret") which would add gzip compression and AES encryption like the current export/import do?

@erikdubbelboer
Copy link
Contributor Author

Since the code is already there I think the second option would be nicer. If users want to do their own compression and encryption they still can be using db.Export(myWriter, false, "").

@philippgille
Copy link
Owner

Sounds good 👍

I started already, but might only finish it over the weekend.

This was referenced Apr 29, 2024
@philippgille
Copy link
Owner

Hi @erikdubbelboer , I've implemented it. Would you mind reviewing:

@erikdubbelboer
Copy link
Contributor Author

Looks good 👍

@philippgille
Copy link
Owner

Thanks!

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants