Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't the TonelRepositoryTest be running the inherited tests as well as the tests defined for Tonel? #13

Open
dalehenrich opened this issue Nov 9, 2017 · 3 comments

Comments

@dalehenrich
Copy link

Only two tests are being run, but there are a number of other tests that could be inherited.

I think that shouldInheritSelectors needs to be implemented to return true on the class-side to run the tests ...

@dalehenrich
Copy link
Author

Hmm, I was looking Pharo7.0, above, for Pharo6.0 and my most recent modifications, there are more tests being run and not all of the inherited tests are passin ... odd that different builds result in different tests being run ... ...

I'll add shouldInheritSelectors, because GemStone needs that anyway ...

@dalehenrich
Copy link
Author

... on another note, each of the failing tests would need a port to Tonel I think, since they seem to be testing the Monticello meta data aspects --- so I've wired them out and flagged as a #todo

@estebanlm
Copy link
Contributor

yeah, I didn't port them explicitly since they seemed to no have sense in the tonel context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants