Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MemoryLeak: Charge sorter #3165

Closed
jecisc opened this issue Apr 11, 2019 · 7 comments
Closed

MemoryLeak: Charge sorter #3165

jecisc opened this issue Apr 11, 2019 · 7 comments

Comments

@jecisc
Copy link
Member

jecisc commented Apr 11, 2019

In an image, I worked on Change Sorter and after I finished I ran some GC but I still had instances in my image.

It's possible we have a memory leak.

@Ducasse
Copy link
Member

Ducasse commented Apr 21, 2019

There should be one instance to hold the changes. Now not multiple ones.

@akgrant43
Copy link
Collaborator

Not sure if this is related, but the window title suggests a similar issue:

"a SpecWindow(784367360) named: Dual Change Sorter on: Unnamed on: Unnamed on: Unnamed"

(I'd expect only one "on: Unnamed")

@Ducasse
Copy link
Member

Ducasse commented Apr 22, 2019

Yes :)

@jecisc
Copy link
Member Author

jecisc commented Apr 22, 2019

It will be fixed with spec 2 synch

@stale
Copy link

stale bot commented Dec 28, 2019

To limit bug bankruptcy (see https://www.joelonsoftware.com/2012/07/09/software-inventory/) this issue has been automatically marked as stale because it has not had any activity in 6 months. If no further activity occurs, it might be closed. If this issue remains important to you, please comment to reactivate the issue. Thank you for your contributions.

Joel on Software
Imagine, for a moment, that you came upon a bread factory for the first time. At first it just looks like a jumble of incomprehensible machinery with a few people buzzing around. As your eyes adjus…

@stale stale bot added the stale label Dec 28, 2019
@astares
Copy link
Member

astares commented Dec 28, 2019

Still valid

@stale stale bot removed the stale label Dec 28, 2019
@guillep
Copy link
Member

guillep commented Jan 27, 2023

I don't think this is a memory leak, ChangeSet has always stored a default instance in a singleton.
Avoiding this could mean storing change sets in disk for example. That would require an entire redesign.
I propose to write that down in a wiki as a potential project and close this issue.

Of course, please reopen if there is a concrete issue we can deal with.

@guillep guillep closed this as completed Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants