Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.2.3] build issue with zephir 0.10 and timecop extension #13117

Closed
remicollet opened this issue Oct 13, 2017 · 6 comments · Fixed by zephir-lang/zephir#1588
Closed

[3.2.3] build issue with zephir 0.10 and timecop extension #13117

remicollet opened this issue Oct 13, 2017 · 6 comments · Fixed by zephir-lang/zephir#1588

Comments

@remicollet
Copy link
Contributor

Using:

  • php-zephir-parser 1.1.0
  • zephir 0.10.3
  • phalcon 3.2.3
+ /usr/bin/zephir generate --backend=ZendEngine3
Warning: Variable "reflectionMethod" declared but not used in Phalcon\Dispatcher::dispatch in /dev/shm/BUILD/cphalcon-a8635777097ac4b3ad6c51ec6bc1fe5fb86ca90e/phalcon/dispatcher.zep on 420 [unused-variable]

	   actionSuffix, handlerClass, status, actionMethod, reflectionMethod, methodParams,
	---------------------------------------------------------------------^


Warning: Variable "methodParams" declared but not used in Phalcon\Dispatcher::dispatch in /dev/shm/BUILD/cphalcon-a8635777097ac4b3ad6c51ec6bc1fe5fb86ca90e/phalcon/dispatcher.zep on 420 [unused-variable]

	   actionSuffix, handlerClass, status, actionMethod, reflectionMethod, methodParams,
	-----------------------------------------------------------------------------------^


Warning: Variable "className" declared but not used in Phalcon\Dispatcher::dispatch in /dev/shm/BUILD/cphalcon-a8635777097ac4b3ad6c51ec6bc1fe5fb86ca90e/phalcon/dispatcher.zep on 421 [unused-variable]

	   className, paramKey, methodParam, modelName, modelBinder, bindModel, bindCacheKey,
	------------^


Warning: Variable "paramKey" declared but not used in Phalcon\Dispatcher::dispatch in /dev/shm/BUILD/cphalcon-a8635777097ac4b3ad6c51ec6bc1fe5fb86ca90e/phalcon/dispatcher.zep on 421 [unused-variable]

	   className, paramKey, methodParam, modelName, modelBinder, bindModel, bindCacheKey,
	----------------------^


Warning: Variable "methodParam" declared but not used in Phalcon\Dispatcher::dispatch in /dev/shm/BUILD/cphalcon-a8635777097ac4b3ad6c51ec6bc1fe5fb86ca90e/phalcon/dispatcher.zep on 421 [unused-variable]

	   className, paramKey, methodParam, modelName, modelBinder, bindModel, bindCacheKey,
	-----------------------------------^


Warning: Variable "modelName" declared but not used in Phalcon\Dispatcher::dispatch in /dev/shm/BUILD/cphalcon-a8635777097ac4b3ad6c51ec6bc1fe5fb86ca90e/phalcon/dispatcher.zep on 421 [unused-variable]

	   className, paramKey, methodParam, modelName, modelBinder, bindModel, bindCacheKey,
	----------------------------------------------^


Warning: Variable "bindModel" declared but not used in Phalcon\Dispatcher::dispatch in /dev/shm/BUILD/cphalcon-a8635777097ac4b3ad6c51ec6bc1fe5fb86ca90e/phalcon/dispatcher.zep on 421 [unused-variable]

	   className, paramKey, methodParam, modelName, modelBinder, bindModel, bindCacheKey,
	----------------------------------------------------------------------^


Warning: Variable "beforeLine" assigned but not used in Phalcon\Debug::showTraceItem in /dev/shm/BUILD/cphalcon-a8635777097ac4b3ad6c51ec6bc1fe5fb86ca90e/phalcon/debug.zep on 339 [unused-variable]

	   beforeLine, firstLine, afterLine, lastLine, i, linePosition, currentLine,
	-------------^


Method '__construct' was defined more than one time

I probably miss some change in the build process, but can find anything in the diff with 3.2.2

@remicollet remicollet changed the title build issue [3.2.3] build issue with zephir 0.10 Oct 13, 2017
@remicollet
Copy link
Contributor Author

Digging a bit more, seems to be a incompatibility with some installed extensions, "zephir" work in a minimal build env.

@sergeyklay
Copy link
Contributor

@remicollet Good catch. Keep my informed of any news

@sergeyklay
Copy link
Contributor

Just to you know all these warnings (introduced in #13112 by @virgofx) are not real issues. They are just garbage, which will be cleared by the compiler. We'll fix them in future releases.

@remicollet
Copy link
Contributor Author

I finally found time to dig more, the faulty extension is timecop

Without it, zephir works, with it zephir fails with Method '__construct' was defined more than one time

@sergeyklay
Copy link
Contributor

Well, can we close this for now?

@remicollet remicollet changed the title [3.2.3] build issue with zephir 0.10 [3.2.3] build issue with zephir 0.10 and timecop extension Oct 13, 2017
@remicollet
Copy link
Contributor Author

remicollet commented Oct 13, 2017

Perhaps may be helpful to add some comment in zephir doc, or to display a message if the extension is detected (because hard to find when you have ~180 extensions enabled). Else can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants