Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for SQLAlchemy 2 #648

Open
mhotzel opened this issue Aug 9, 2023 · 0 comments
Open

support for SQLAlchemy 2 #648

mhotzel opened this issue Aug 9, 2023 · 0 comments
Labels
Feature A nice to have thing that we don't have yet Help Wanted We are volunteers. We'll be happy if you join us.

Comments

@mhotzel
Copy link

mhotzel commented Aug 9, 2023

Problem description

At the moment, petl works with sqlalchemy 1.4. When I try to use it with sqlalchemy 2, "todb" doesn't work, because it seems so, that it checks the type of "dbo" by checking the existence of properties and methods, which do not all exists in sqlalchemy.Engine and sqlalchemy.Connection.

Change description

Describe the solution you'd like

I'm not experienced enough, to be save, but I would say, it would be good also to check against the dbo properties und methods in sqlalchemy 2

Advantages

It would work with sqlalchemy 2 too

Describe alternatives you've considered

I didn't have an idea, but to change to sqlalchemy 1.4

@mhotzel mhotzel added the Feature A nice to have thing that we don't have yet label Aug 9, 2023
@juarezr juarezr added the Help Wanted We are volunteers. We'll be happy if you join us. label Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature A nice to have thing that we don't have yet Help Wanted We are volunteers. We'll be happy if you join us.
Projects
None yet
Development

No branches or pull requests

2 participants