Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider removing tag requirements for vector and matrix in the yaml parser #188

Closed
jslee02 opened this issue Apr 22, 2017 · 0 comments · Fixed by #200
Closed

Consider removing tag requirements for vector and matrix in the yaml parser #188

jslee02 opened this issue Apr 22, 2017 · 0 comments · Fixed by #200

Comments

@jslee02
Copy link
Member

jslee02 commented Apr 22, 2017 •
edited
Loading

In a yaml file, we currently need to specify tags for vector and matrix (i.e., !Vector and !Matrix) type in advance like:

left:
  default: !Matrix &left_default
    [[0., 0., 1., 0.],
     [1., 0., 0., 0.],
     [0., 1., 0., .18],
     [0., 0., 0., 1.]]
  cylinder: *left_default

We could remove the tag requirement by checking if the node is sequence (for vector) or nested sequence (for matrix).

Related PR: #175
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove tag requirements for vector/matrix in YAML personalrobotics/aikido
1 participant
@jslee02