Undefined index: page

[Mte90]

An user reported a bug with xhgui,

xhgui/src/Xhgui/Searcher/PdoSearcher.php

Line 101 in e7d4d21

$page = (int)$options['page'];

From here https://github.com/perftools/xhgui/blob/master/src/Xhgui/Searcher/PdoSearcher.php#L101 it is not clear if that key exists.

[glensc]

🚧 Never link to branches, share a permalink 🚧

• see https://news.ycombinator.com/item?id=8046710
  and https://help.github.com/articles/getting-permanent-links-to-files/
  and https://docs.gitlab.com/ee/user/shortcuts.html#project-files
• hit y
• and perhaps for https://github.com/josephfrazier/octopermalinker (GitHub)

NOTE: edit your post and fix it with a permalink!

[Mte90]

Sorry I forgot it again

[glensc]

This PR covers this topic: #363

but I have not able to test the branch other than making the CI pass.

[Mte90]

I don't see any error.

[glensc]

I don't see any error.

???

[Mte90]

Sorry I meant that I tested with that branch and I don't see any error.

[glensc]

You could have said that in that PR then, would be made more sense.

merging it then.