Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish docker images #311

Closed
glensc opened this issue Aug 27, 2020 · 5 comments
Closed

Publish docker images #311

glensc opened this issue Aug 27, 2020 · 5 comments

Comments

@glensc
Copy link
Contributor

glensc commented Aug 27, 2020

We should publish pre-built docker images, so that setting up an instance is faster. as currently, the build process takes some time. and save green energy! πŸ‘

βž” time docker build --no-cache .
real	2m8.080s
user	0m1.258s
sys	0m1.331s

This kind of also ensures the builds are verified to be working the same for everybody (we don't track composer.lock, so the outcome may vary depending on when you build).

In the future, we could build separate mongo and pdo variants.

@glensc
Copy link
Contributor Author

glensc commented Sep 1, 2020

@markstory can you organize access please:

create org on hub.docker.com and add user glen access to push.
or you prefer to use github infra (they have also docker registry support)?

I've personally have not used github infra or dockerhub automation, so I'd go with manual pushing to dockerhub.

@glensc
Copy link
Contributor Author

glensc commented Sep 1, 2020

Re: variants

I don't think we need multiple variants, rather add support for both modules. it's just PHP extensions.

@markstory
Copy link
Member

@glensc I created the dockerhub org and added you as an owner. πŸ˜„

@glensc
Copy link
Contributor Author

glensc commented Sep 7, 2020

published for the last tag (0.13.0):

@glensc
Copy link
Contributor Author

glensc commented Sep 14, 2020

PR adding more pdo drivers: #323

@glensc glensc closed this as completed Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants