From 5e3bb2569b76d114b014fce520b0a427108935c8 Mon Sep 17 00:00:00 2001 From: katelyn martin Date: Tue, 28 May 2024 00:00:00 +0000 Subject: [PATCH] =?UTF-8?q?dex:=20=F0=9F=AA=A3=20add=20two=20larger=20dex?= =?UTF-8?q?=20buckets?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit fixes #4464. this adds two larger buckets to the dex component's histograms. when our dashboards calculate quantiles, we observed signals that some operations were taking longer than 100ms. to help obtain more accurate performance data, we add a 1 second and 10 second bucket. --- crates/core/component/dex/src/component/metrics.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/core/component/dex/src/component/metrics.rs b/crates/core/component/dex/src/component/metrics.rs index 056f3bd172..c8672228de 100644 --- a/crates/core/component/dex/src/component/metrics.rs +++ b/crates/core/component/dex/src/component/metrics.rs @@ -46,7 +46,7 @@ pub fn register_metrics() { // Prometheus metrics are structured as a Histogram, rather than as a Summary. // These values are loosely based on the initial Summary output, and may need to be // updated over time. -pub const DEX_BUCKETS: &[f64; 5] = &[0.00001, 0.0001, 0.001, 0.01, 0.1]; +pub const DEX_BUCKETS: &[f64] = &[0.00001, 0.0001, 0.001, 0.01, 0.1, 1_f64, 10_f64]; pub const DEX_PATH_SEARCH_DURATION: &str = "penumbra_dex_path_search_duration_seconds"; pub const DEX_ROUTE_FILL_DURATION: &str = "penumbra_dex_route_fill_duration_seconds";