Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alt fee token support to pcli #4331

Open
Tracked by #4326 ...
hdevalence opened this issue May 6, 2024 · 1 comment
Open
Tracked by #4326 ...

Add alt fee token support to pcli #4331

hdevalence opened this issue May 6, 2024 · 1 comment
Labels
A-client Area: Design and implementation for client functionality A-fees Area: Relates to transaction fees _P-medium Medium priority

Comments

@hdevalence
Copy link
Member

hdevalence commented May 6, 2024

As described in #4320,

Change the pcli tx command so that the existing --fee-tier and a new
--fee-token parameters move to pcli tx, and apply to all subcommands
(i.e., pcli tx --fee-tier ... --fee-token gm send ...) so that TxCmd::exec
can pull the right GasPrices out of the RPC response.

This will be primarily a mechanical refactoring to make the clap arguments work. Otherwise, there will be no changes required to pcli.

Currently, the fee tier argument is appended to every pcli tx subcommand, it should be lifted to the tx command as part of this refactoring

@github-project-automation github-project-automation bot moved this to Backlog in Penumbra May 6, 2024
@github-actions github-actions bot added the needs-refinement unclear, incomplete, or stub issue that needs work label May 6, 2024
@aubrika aubrika added _P-V1 Priority: slated for V1 release _P-medium Medium priority and removed needs-refinement unclear, incomplete, or stub issue that needs work labels May 8, 2024
@hdevalence
Copy link
Member Author

Currently the RPC responses don't include alternative gas tokens so an initial implementation would add the flag, then use the provided denom unit to look for that gas price and error out because it's missing. That's fine, this issue is just about adding the flag.

@cratelyn cratelyn added A-client Area: Design and implementation for client functionality A-fees Area: Relates to transaction fees labels May 9, 2024
@aubrika aubrika removed the _P-V1 Priority: slated for V1 release label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-client Area: Design and implementation for client functionality A-fees Area: Relates to transaction fees _P-medium Medium priority
Projects
Status: Backlog
Development

No branches or pull requests

3 participants