Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ibc: add memo field to ICS20 FungibleTokenPacketData #3762

Closed
avahowell opened this issue Feb 7, 2024 · 0 comments · Fixed by #3767
Closed

ibc: add memo field to ICS20 FungibleTokenPacketData #3762

avahowell opened this issue Feb 7, 2024 · 0 comments · Fixed by #3767
Assignees

Comments

@avahowell
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Since the implementation of cosmos/ibc#584, the standard packet data for ICS20 transfers adds a new field, memo: string, in order to support more complex uses of interchain transfers. Our ICS20 implementation was written before this change was widely adopted by the ecosystem (as it is now), and as such doesn't contain this memo field in FungibleTokenPacketData.

Describe the solution you'd like
We should upgrade our IBC protos to the current interchain standard that includes the memo field. I don't think we need to populate it in our state machine, just updating the protos (and any associated domain types) should be sufficient. This change should be implemented in ibc-types.

@avahowell avahowell self-assigned this Feb 7, 2024
@github-project-automation github-project-automation bot moved this to Future in Testnets Feb 7, 2024
@github-project-automation github-project-automation bot moved this to 🗄️ Backlog in Penumbra Feb 7, 2024
@github-project-automation github-project-automation bot moved this from 🗄️ Backlog to Done in Penumbra Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Status: Future
Development

Successfully merging a pull request may close this issue.

1 participant