Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PoV overestimate fix of pallet-contracts to foucoco #425

Closed
TorstenStueber opened this issue Feb 24, 2024 · 1 comment
Closed

Add PoV overestimate fix of pallet-contracts to foucoco #425

TorstenStueber opened this issue Feb 24, 2024 · 1 comment
Assignees

Comments

@TorstenStueber
Copy link
Contributor

We can't run Nabla on Foucoco because pallet-contracts has a few bugs that over estimates the proofSize.

More context here and here.

I could successfully test that cherry picking this fix to pallet-contracts partially solves this problem so that Nabla works.

To do

Instead of using the official polkadot-v0.9.40 version of pallet-contracts, use the version in this PR

Next Steps

This is supposed to be a quick fix in order to ensure that Nabla runs on Foucoco.
Fortunately, the above fix is already included in polkadot version 0.9.42 so that we will cleanly include it to our runtimes when upgrading to version 0.9.42.

@TorstenStueber TorstenStueber self-assigned this Feb 24, 2024
@TorstenStueber TorstenStueber changed the title Add PoV overestimate for pallet-contracts to foucoco Add PoV overestimate fix of pallet-contracts to foucoco Feb 24, 2024
@TorstenStueber TorstenStueber linked a pull request Feb 25, 2024 that will close this issue
@TorstenStueber
Copy link
Contributor Author

All of this has been executed now. Closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant