Skip to content

Commit

Permalink
feat: change default Elasticsearch API version to 2.4
Browse files Browse the repository at this point in the history
Newer versions of `elasticsearch-js` ship only with support for the highest minor
version of old major elasticsearch versions. We currently use 2.3 in
production for Mapzen Search, but as mentioned in the changelog[1],
using API version 2.4 will work just fine. As defined in the rules of
semver, only new API calls could be added, in 2.4, so anything that
works in 2.3 will still be fine.

Changing this version allows us to upgrade to newer versions of
`elasticsearch-js` which support the latest versions of Elasticsearch 5,
making it easier to upgrade.

[1] https://www.elastic.co/guide/en/elasticsearch/client/javascript-api/current/changelog.html#_13_0_0_apr_24_2017
  • Loading branch information
orangejulius committed Jul 18, 2017
1 parent f77818f commit a5bc5fc
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion config/defaults.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"esclient": {
"apiVersion": "2.3",
"apiVersion": "2.4",
"keepAlive": true,
"requestTimeout": "120000",
"hosts": [{
Expand Down
2 changes: 1 addition & 1 deletion config/expected-deep.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"esclient": {
"apiVersion": "2.3",
"apiVersion": "2.4",
"keepAlive": true,
"requestTimeout": "120000",
"hosts": [{
Expand Down

0 comments on commit a5bc5fc

Please sign in to comment.