Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: sender.login is replaced with whoever added the label #261

Closed
Andre601 opened this issue Sep 1, 2020 · 4 comments
Closed

Bug: sender.login is replaced with whoever added the label #261

Andre601 opened this issue Sep 1, 2020 · 4 comments
Assignees
Labels
bug Something isn't working proposal

Comments

@Andre601
Copy link
Contributor

Andre601 commented Sep 1, 2020

Describe the bug
The {{ sender.login }} placeholder seems to get replaced with whoever was the person labeling the issue, causing stuff like mentions to mention the wrong person

To Reproduce
Steps to reproduce the behavior:

  1. Use the {{ sender.login }} placeholder in a comment
  2. Label an issue that triggers this comment

Expected behavior
The placeholder should instead show the actual issuer of said issue or PR (See additional context for possible solution)

Screenshots

Your YAML file

Additional context
According to Webhook events and payload help article is there an issue and pull_request object respectively that contains a user object with login (the name).
This seems to be the actual name of the person creating the issue while sender.login seems to just be whoever triggered the event.
So the action should perhaps be changed to that instead if possible.

@Andre601 Andre601 added the bug Something isn't working label Sep 1, 2020
@peaceiris
Copy link
Owner

That is my misunderstanding about sender.login. Thank you for reporting this.

@Andre601
Copy link
Contributor Author

Has this been worked on? Would really like a fix for it as we use quite a few comment templates that mention the issue/pr author.

@github-actions
Copy link
Contributor

Thank you @Andre601 for suggesting this.

@peaceiris
Copy link
Owner

@{{ issue.user.login }} is available now.

Closed by #272

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working proposal
Projects
None yet
Development

No branches or pull requests

2 participants