Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Custom docker socket #386

Open
Klubas opened this issue Aug 26, 2022 · 2 comments
Open

[Feature request] Custom docker socket #386

Klubas opened this issue Aug 26, 2022 · 2 comments

Comments

@Klubas
Copy link

Klubas commented Aug 26, 2022

I'm using BalenaOS, and it uses balena-engine instead of docker.

If I enable Docker integration i get the error "[ERROR] Can't connect to the Docker API on localhost", that could be solved changing the docker socket to "unix:///var/run/balena-engine.sock" here
https://github.com/pawelmalak/flame/blob/master/controllers/apps/docker/useDocker.js

I >think< it could be implemented using an environment variable. If there's is interest I can make a pull request with this option.

@el-joseppe
Copy link

this would be also necessary for anyone (like myself) who wants to limit the docker-socket-access via a docker-socket-proxy! So I would appreciate the addition to configure the socket via environment variable!

@Klubas
Copy link
Author

Klubas commented Nov 8, 2022

Finally got around to making a PR for this. #396

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants