Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Unable to edit bookmarks #239

Closed
RmigD opened this issue Dec 1, 2021 · 4 comments · Fixed by #241
Closed

[BUG] Unable to edit bookmarks #239

RmigD opened this issue Dec 1, 2021 · 4 comments · Fixed by #241

Comments

@RmigD
Copy link

RmigD commented Dec 1, 2021

Deployment details:

  • App version [e.g. v1.7.4]: 2.1.0
  • Platform [e.g. amd64, arm64, arm/v7]: amd64
  • Docker image tag [e.g. latest, multiarch]: pawelmalak/flame latest

Bug description:
After updating to the latest version, I am unable to edit bookmarks. I expected to see a list of bookmarks and edit buttons, but I see a single string "Switch to grid view and click on the name of category you want to edit". No idea what this grid is.

Steps to reproduce:

  1. Go to homepage
  2. Click on Bookmarks
  3. Click on "Edit bookmarks"
    flame

Just before submitting this, I found a way to edit, but it doesn't seem right.... I go into "edit categories", I click the pencil icon, I close the popup that shows up. I can then go into "edit bookmarks" and see the bookmarks that belong to the category I clicked on before. This doesn't seem very intuitive or efficient. I will submit this ticket just the same, but feel free to close it...

@pawelmalak
Copy link
Owner

Just click on "edit bookmarks" again and it will change view to grid mode. Then just click on category name you want to edit.

@RmigD
Copy link
Author

RmigD commented Dec 1, 2021

Clicking "edit Bookmarks" twice and then clicking on the name of the category to which the bookmark is assigned works. I would do this differently. I would not require a second click in "edit Bookmarks" and I would skip the clicking on the category. So when clicking "edit Bookmarks", just show all of them. Isn't this what it was like before?

@pawelmalak
Copy link
Owner

It was, but it had to be changed to implement option to set custom order for bookmarks.

@ctrpch
Copy link

ctrpch commented Dec 2, 2021

Deployment details:

* App version [e.g. v1.7.4]: 2.1.0

* Platform [e.g. amd64, arm64, arm/v7]: amd64

* Docker image tag [e.g. latest, multiarch]: pawelmalak/flame latest

Bug description:

After updating to the latest version, I am unable to edit bookmarks. I expected to see a list of bookmarks and edit buttons, but I see a single string "Switch to grid view and click on the name of category you want to edit". No idea what this grid is.

Steps to reproduce:

1. Go to homepage

2. Click on Bookmarks

3. Click on "Edit bookmarks"
   ![flame](https://user-images.githubusercontent.com/31237907/144328770-76a3c2b8-0613-4505-a56f-8a8e5fc1ce94.png)

Just before submitting this, I found a way to edit, but it doesn't seem right.... I go into "edit categories", I click the pencil icon, I close the popup that shows up. I can then go into "edit bookmarks" and see the bookmarks that belong to the category I clicked on before. This doesn't seem very intuitive or efficient. I will submit this ticket just the same, but feel free to close it...

I had the same issue and this work-around did allow me to edit the bookmarks

@pawelmalak pawelmalak changed the title [BUG] [BUG] Unable to edit bookmarks Dec 2, 2021
@pawelmalak pawelmalak linked a pull request Dec 2, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants