Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Allow .ico + .svg to be set #209

Closed
modem7 opened this issue Nov 19, 2021 · 4 comments · Fixed by #226
Closed

[Feature Request] Allow .ico + .svg to be set #209

modem7 opened this issue Nov 19, 2021 · 4 comments · Fixed by #226
Labels
🔨 Feature New feature or request

Comments

@modem7
Copy link

modem7 commented Nov 19, 2021

In addition to #138, would it be possible to allow .ico and .svg in addition to jpeg, jpg, png?

Thanks!

@modem7 modem7 changed the title Allow .ico to be set [Feature Request] Allow .ico to be set Nov 19, 2021
@modem7 modem7 changed the title [Feature Request] Allow .ico to be set [Feature Request] Allow .ico + .svg to be set Nov 19, 2021
@pawelmalak
Copy link
Owner

SVG is already supported

@Unkn0wnCreator
Copy link

Maybe automatically use favicon if no icon chosen

@modem7
Copy link
Author

modem7 commented Nov 19, 2021

Maybe automatically use favicon if no icon chosen

Good shout, was also thinking that I have a collection of icons, and some are .ico (https://github.com/modem7/MiscAssets) as it just makes it easier for myself at least (and some apps only provide the .ico)

@pawelmalak pawelmalak added the 🔨 Feature New feature or request label Nov 20, 2021
@nomandera
Copy link

If there is scope to discuss this then there are curated asset lists ready made out there that could be consumed today.

https://github.com/linuxserver/Heimdall-Apps

A process to normalise to the white on transparent material design icons would be created but this should be simple enough to even be done on the fly.

@pawelmalak pawelmalak linked a pull request Nov 25, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 Feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants